fix: auto assign dependabot[bot]#1306
Conversation
Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>
|
Hey @Egbaiyelo 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1283 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
github-actions
bot
added
the
status: needs review
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
rwalworth
left a comment
rwalworth
left a comment
There was a problem hiding this comment.
Hey @Egbaiyelo - nice work on this one! The fix is correct, well-scoped, and you correctly followed the guidance about putting tests in test-api.js rather than test-utils.js. The regex approach - anchoring [bot] as an optional suffix rather than opening up [ and ] broadly - is the right call security-wise. The six test cases cover the important accept/reject paths clearly.
I left two small non-blocking comments below - feel free to address them if you'd like, but they won't hold up the merge. If you'd rather skip them, I'm happy to open them up as Good First Issues for other contributors to pick up.
Once we get an approval from @hiero-ledger/github-maintainers and workflows pass, I will merge this!
rwalworth
removed
the
status: needs review
|
@rwalworth can I write the good first issues for those two, whatever i feel needs to be added, Ill put it there |
|
Hey @Egbaiyelo, sure go ahead! |
Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca>
Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca> Signed-off-by: ParasSalonia <parassalonia22@gmail.com>
Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca> Signed-off-by: ParasSalonia <parassalonia22@gmail.com>
Signed-off-by: Egbaiyelo <moteniolaegbaiyelo@trentu.ca> Signed-off-by: ParasSalonia <parassalonia22@gmail.com>
3 participants
Description:
Fixing the dependabot auto-assign while ensuring that the logic isn't to tolerant
Adding tests for the updated method
Related issue(s):
Fixes #1283
Notes for reviewer:
Checklist